fix: tweak the arg shapes to improve tool accuracy #381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirinchev
commented
Jul 17, 2025
| .optional() | ||
| .describe("The projection, matching the syntax of the projection argument of db.collection.find()"), | ||
| limit: z.number().optional().default(10).describe("The maximum number of documents to return"), | ||
| sort: z | ||
| .record(z.string(), z.custom<SortDirection>()) | ||
| .object({}) | ||
| .catchall(z.custom<SortDirection>()) |
There was a problem hiding this comment.
This, unfortunately, doesn't correctly set the type for additionalProperties in the JSON schema. This is the reason I had to update the tool description to be extra verbose.
himanshusinghs
force-pushed
the
chore/issue-307-proposal-2
branch
from
8488144 to
ec52ee5
Compare
nirinchev
force-pushed
the
poc/unconsolidated/1
branch
from
fe53d4f to
39b428d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The core fix here is moving away from
z.recordand using a plainz.object({}).passthrough(). The test changes are fixes to what seems to have been copy-paste errors where the prompt and the expectations were mismatched.Checklist